feat(bsp_graphics_lvgl): Created new component for BSP graphics (LVGL) and removed LVGL from BSP#774
feat(bsp_graphics_lvgl): Created new component for BSP graphics (LVGL) and removed LVGL from BSP#774espzav wants to merge 1 commit into
Conversation
Test Results32 tests 32 ✅ 1m 35s ⏱️ Results for commit 909e813. ♻️ This comment has been updated with latest results. |
espzav
force-pushed
the
feat/split_bsp
branch
14 times, most recently
from
4e17b45 to
6809fa5
Compare
…) and removed LVGL from BSP
|
Hi @tore-espressif, @igrr, @PetrESP, @georgik this is the proposal of the splitting BSP to noglib part + new component graphics (LVGL).
Please, could you look at it and give me some feedback? Thank you! |
espzav
changed the title
| /******************************************************************************* | ||
| * Private functions | ||
| *******************************************************************************/ | ||
| static lv_display_t *bsp_display_lcd_init(const bsp_display_cfg_t *cfg) |
There was a problem hiding this comment.
@espzav IIUC, this function should be 'generic' and working on all boards. However, it initializes DSI peripheral. Is there a plan to move the DSI specific part to the respective BSP?
Can we make this function more generic so it compile and run on all BSPs?
There was a problem hiding this comment.
@tore-espressif This function returns lv_display_t, this is type from LVGL. It initializes LVGL, it cannot be generic.
There was a problem hiding this comment.
Sure, it is tight to LVGL.
But, it also initializes DSI. This will not work on eg. ESP32-S3. Will we have several versions of this funciton? (eg. for DSI, SPI and i8080 backed displays?)
|
I was validating the concept.
I recommend to remove the selection of NOGLIB and LVGL, because in the project you have a graphical library and they have different APIs, so it does not make sense to switch them in menuconfig, since each would handle graphics differently. |
3 participants
ESP-BSP Pull Request checklist
Change description
Please describe your change here